Skip to content

Commit

Permalink
fix linter staticcheck -ST1022 (zalando#1642)
Browse files Browse the repository at this point in the history
Signed-off-by: Sandor Szücs <[email protected]>
  • Loading branch information
szuecs authored Dec 8, 2020
1 parent 9130fa5 commit c268dfb
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ vet: $(SOURCES)
# -ST1021 too many wrong comments on exported functions to fix right away
# -ST1022 too many wrong comments on exported functions to fix right away
staticcheck: $(SOURCES)
GO111MODULE=$(GO111) .bin/staticcheck -checks "all,-ST1000,-ST1003,-ST1012,-ST1020,-ST1021,-ST1022" $(PACKAGES)
GO111MODULE=$(GO111) .bin/staticcheck -checks "all,-ST1000,-ST1003,-ST1012,-ST1020,-ST1021" $(PACKAGES)

# TODO(sszuecs) review disabling these checks, f.e.:
# G101 find by variable name match "oauth" are not hardcoded credentials
Expand Down
2 changes: 1 addition & 1 deletion filters/filters.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ type Spec interface {
// Registry used to lookup Spec objects while initializing routes.
type Registry map[string]Spec

// Error used in case of invalid filter parameters.
// ErrInvalidFilterParameters is used in case of invalid filter parameters.
var ErrInvalidFilterParameters = errors.New("invalid filter parameters")

// Registers a filter specification.
Expand Down
2 changes: 1 addition & 1 deletion predicates/cookie/cookie.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
"github.com/zalando/skipper/routing"
)

// The predicate can be referenced in eskip by the name "Cookie".
// Name the predicate can be referenced in eskip by the name "Cookie".
const Name = "Cookie"

type (
Expand Down
2 changes: 1 addition & 1 deletion predicates/predicates.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ package predicates

import "errors"

// Error used in case of invalid predicate parameters.
// ErrInvalidPredicateParameters is used in case of invalid predicate parameters.
var ErrInvalidPredicateParameters = errors.New("invalid predicate parameters")

0 comments on commit c268dfb

Please sign in to comment.