fix: correctly restrict skelewags spawned at structures #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous if-statement never returned true
|
oi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous if-statement never returned true, as
MobSpawnType.STRUCTUREonly applies when an entity that is saved in an NBT structure is placed in the world (e.g., the initial Iron Golem at villages). Even when Skelewags spawned at shipwrecks in case therestrictSkelewagSpawnsconfig option is enabled (which only rarely happens by the way, please see #2257 for that issue), the spawn type was alwaysMobSpawnType.NATURAL, so the Skelewags were never restricted to a maximum movement radius.