Add shouldRemove in upload method to delete file after successful upload
#3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sful upload - Add test case `testFileUploadSuccessAndDeletion` to `UploadTests.swift` - Verify that the file is uploaded successfully to the specified endpoint - Verify that the file is deleted after successful upload completion Additionally, this commit includes the following changes: - Updated documentation for `upload` function in Alamofire - Added parameter for controlling file deletion of a file after successful upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
shouldRemoveto the Alamofire upload function to control whether the uploaded file should be removed after upload completion.Implementation Details 🚧
shouldRemoveparameter allows users to specify whether the file should be deleted after upload, providing more flexibility and control.Session'suploadfunction for file uploading and properly documented to maintain consistency with the naming convention used forUploadable'scase file(URL, shouldRemove: Bool).shouldRemoveparameter as other upload tests to maintain consistency across the codebase.Testing Details 🔍
Test case
testFileUploadSuccessAndDeletionis added to existingUploadTeststo validate the file upload success and deletion functionality.