Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove DD metrics reporting from CI #10930

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

mujahidkay
Copy link
Member

@mujahidkay mujahidkay commented Feb 3, 2025

Apparently, our contract with DD run till September. Pending confirmation, this PR will remain draft. Integration test and benchmark results DO NOT get reported GCP right now. Ideally, we should only merge this when we handle these two but not a hard requirement IMO.

closes: ticket

Description

Removes all Datadog related integration for reporting test metrics. Also removes additional helper scripts. In its current state, we are also disabling reporting for vaults stress benchmark and test-docker-build integration test result (have created separated tickets for them under SRE). Post merge, we can remove DD secrets from this repo.

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

Its CI only so None

Testing Considerations

all CI. Like mentioned in the description, in its current state, we will miss out on benchmark and integration test result metrics because our existing gcp CI reporting script doesn't handle these two cases.

Upgrade Considerations

None

@mujahidkay mujahidkay self-assigned this Feb 3, 2025
Copy link

cloudflare-workers-and-pages bot commented Feb 3, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: a7be9a1
Status: ✅  Deploy successful!
Preview URL: https://15cb4b5d.agoric-sdk.pages.dev
Branch Preview URL: https://mk-dd-removal.agoric-sdk.pages.dev

View logs

@mujahidkay mujahidkay added the force:integration Force integration tests to run on PR label Feb 3, 2025
@mujahidkay mujahidkay requested a review from Muneeb147 February 6, 2025 11:32
@Muneeb147
Copy link
Contributor

all CI. Like mentioned in the description, in its current state, we will miss out on benchmark and integration test result metrics because our existing gcp CI reporting script doesn't handle these two cases.

@mujahidkay Do have any engineering issue for it as DD sunset follow-up? Also do you think if it is doable as quick-win then we can sync and work on sending the stats first before stopping the DD reporting.
Test metrics which are currently reported to GCP can be removed from datadog.

@frazarshad Thoughts?

@mujahidkay
Copy link
Member Author

all CI. Like mentioned in the description, in its current state, we will miss out on benchmark and integration test result metrics because our existing gcp CI reporting script doesn't handle these two cases.

@mujahidkay Do have any engineering issue for it as DD sunset follow-up? Also do you think if it is doable as quick-win then we can sync and work on sending the stats first before stopping the DD reporting. Test metrics which are currently reported to GCP can be removed from datadog.

@frazarshad Thoughts?

@Muneeb147 I'm not certain how quick of a win would those be. I'm in favor of benching this PR altogether till we port those metrics to GCP (no harm done AFAIK as our contract runs till September) and hopefully we can get this done in a sprint.
I'm also not opposed to your call of removing everything but integration and benchmark reporting so let's make a call on it, and move forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants