Adding a ct.get_all_results() implementation #1901
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1901 +/- ##
===========================================
+ Coverage 84.49% 84.89% +0.39%
===========================================
Files 295 181 -114
Lines 14472 11287 -3185
Branches 195 0 -195
===========================================
- Hits 12228 9582 -2646
+ Misses 2110 1705 -405
+ Partials 134 0 -134
*This pull request uses carry forward flags. Click here to find out more. |
adirao-projects
changed the title
adirao-projects
changed the title
adirao-projects
commented
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an implementation of the
get_all_resultsfunction desired in #1701 . The main issue with the current implementation I've added is that it requires either of the following.If these requirements are not met, the provided implementation will not work. The internal documentation I've provided explains the logic on how everything works. I have not yet updated the external documentation. No tests have been written to test this function yet.