Improve support for remote executors #1885
Open
+263
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1885 +/- ##
===========================================
+ Coverage 84.60% 85.24% +0.63%
===========================================
Files 295 181 -114
Lines 14499 11328 -3171
Branches 195 0 -195
===========================================
- Hits 12267 9656 -2611
+ Misses 2098 1672 -426
+ Partials 134 0 -134
|
cjao
force-pushed
the
improve-file-transfer-selector
branch
from
72beaea
to
7fac492
Compare
cjao
force-pushed
the
improve-file-transfer-selector
branch
3 times, most recently
from
678996e
to
c254d46
Compare
cjao
force-pushed
the
improve-file-transfer-selector
branch
3 times, most recently
from
04fde96
to
1313c44
Compare
cjao
force-pushed
the
improve-file-transfer-selector
branch
2 times, most recently
from
45bb7e2
to
c083aa9
Compare
cjao
force-pushed
the
improve-file-transfer-selector
branch
from
c083aa9
to
3a0aa15
Compare
Handle the following cases: - Local-Remote (except HTTP destination) - Remote-Local - Local-Local This will be needed for to port remote executors to the new runner-executor API.
cjao
force-pushed
the
improve-file-transfer-selector
branch
from
3a0aa15
to
7ec3c58
Compare
cjao
force-pushed
the
improve-file-transfer-selector
branch
6 times, most recently
from
d683fc7
to
2df507c
Compare
`LocalDispatcher.prepare_manifest()` will attempt to copy the task artifacts to `COVALENT_STAGING_URI_PREFIX` if that environment variable is set.
cjao
force-pushed
the
improve-file-transfer-selector
branch
from
ee78a82
to
7467b81
Compare
Since Sqlalchemy is only used server-side, it's an extraneous dependency of the SDK-only install
cjao
force-pushed
the
improve-file-transfer-selector
branch
from
7467b81
to
5d44342
Compare
cjao
force-pushed
the
improve-file-transfer-selector
branch
from
5d44342
to
b8689b1
Compare
cjao
force-pushed
the
improve-file-transfer-selector
branch
from
58d3cf6
to
08158db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR allow remote executors to use the new-style executor API.
(s3, file)and(file, s3)both map to the S3 transfer strategy.COVALENT_STAGING_URI_PREFIXenvironment variable is set (for instance,COVALENT_STAGING_URI_PREFIX="s3://{bucket_name}/{dispatch_id}/sublattices", the executor will deposit the sublattice assets there for the orchestrator to retrieve after the_build_sublattice_graphtask completes (naturally Covalent should have read permissions for that URI prefix).