chore(*): add pre-commit hooks for formatting #157
Conversation
https://dune.readthedocs.io/en/stable/usage.html#finding-the-root This is necessary for tools that tries to work without having `compiler/` as the cwd, e.g. linters. Signed-off-by: Ryan Lahfa <[email protected]>
This avoids the difficult situation where CI yells at me and I force push 5 times after :'(. It works only for Nix shells. Signed-off-by: Ryan Lahfa <[email protected]>
RaitoBezarius
force-pushed
the
commit-hooks
branch
from
664eae3
to
b194ed7
Compare
Yes, of course! |
|
In practice what does this do? It only uses pre commit hooks if you're using nix, right? If that's the case and you consider it's idiomatic when using nix, I'm fine. |
| aeneas-verify-hol4 | ||
| aeneas-check-tidiness; | ||
|
|
||
| pre-commit-check = pre-commit-hooks.lib.${system}.run { |
There was a problem hiding this comment.
I'm not a huge fan of pre-commit hooks because I rebase a lot... I does make sense though, we can try it for a bit
There was a problem hiding this comment.
Can you add a comment here to explain what this does (this formats the code at commit time, etc.)?
|
Now that my editor formats everything automatically I'm not longer keen on having this |
|
This PR seems dead, so I'm closing it. Feel free to reopen it if you really want this feature. |
This adds pre-commit hooks for formatting, because I usually just trust whatever people prefer locally :).
We could add, e.g. rustfmt, but I prefer @sonmarcho that you tell me what you prefer regarding this. Pre-commit hooks can be pesky and annoying.
Signed-off-by: Ryan Lahfa [email protected]