[wip]Use expiresAt for QR payments #2520
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For the following QR based payments -
bcmc_mobile
,duitnow
,payme
,paynow
,pix
,promptpay
,swish
andwechatpayQR
, we improved how we calculate the countdown time.Specifically, we calculate the QR countdown time based on the
expiresAt
timestamp from the/payments
response if it is returned in the action object, otherwise we use merchant's frontend configuration.If both are not presented, we fall back to the default value.
Tested scenarios
Added tests and all unit tests passed.
Tested on my device with different timezones, the wechat QR pay shows a 30mins count down (taking the value from
expiresAt
)Internal ticket: COWEB-1258