Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

success is declared as a boolean when it is a string in production and test environments. #26

Open
LucasRxTx opened this issue Aug 17, 2021 · 0 comments

Comments

@LucasRxTx
Copy link

Describe the bug
success has been declared as a boolean when it is actually a string. Here is one example of many:

"success" : {

To Reproduce
Look at other definitions of success in the openAPI documentation and see that success is a string.
Look at the example notifications in the openAPI documentation; success is a string.
Look at a production notification and see that success is a string.
Look at a testing environment notification and see that success is a string.

Expected behavior
success should be a string. It would have been great if success was actually a boolean, but at this point it has to be a string to break integrations.

Screenshots
None

Desktop (please complete the following information):
irrelevent

Smartphone (please complete the following information):
irrelevent

Additional context
This has caused issues in the past. We have getters for success that coax the value to a boolean if it is a string or a bool because it is unclear in your openAPI spec if success will always be a string, or sometimes may possibly be a bool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant