Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification examples do not adhere to defined schema #25

Open
LucasRxTx opened this issue Aug 17, 2021 · 2 comments
Open

Notification examples do not adhere to defined schema #25

LucasRxTx opened this issue Aug 17, 2021 · 2 comments

Comments

@LucasRxTx
Copy link

LucasRxTx commented Aug 17, 2021

Describe the bug
There are several notification examples that do not adhere to their defined schema.

For example: REPORT_AVAILABLE example notification does not comply with the declared schema for a ReportAvailableNotificationRequestItem. paymentMethod is stated to be required but the example is missing it. It is unclear what schema I should expect the NotificationRequestItem to be.

There are other errors in the schema definitions, for example for success values, though i have reported it as a separate issue: #26

To Reproduce
Look at the openAPI specification for a ReportAvailableNotificationRequestItem and see that paymentMethod is required.
Look at the openAPI specification example response for REPORT_AVAILABLE and see the paymentMethod is not included in the example.

Expected behavior
Both the actual notification, and the example notification should adhere to the declared schema for REPORT_AVAILABLE.

Screenshots
None

Desktop (please complete the following information):
irrelevant

Smartphone (please complete the following information):
irrelevant

Additional context
Using your example responses to create a mock server causes errors in our test system. We are now unsure of the actual expected schema for notifications.

@LucasRxTx
Copy link
Author

This seems to be the case in other notifications as well

for example:

@LucasRxTx LucasRxTx changed the title REPORT_AVAILABLE example does not adhere to defined schema Notification examples do not adhere to defined schema Aug 17, 2021
@PPKFS
Copy link

PPKFS commented Oct 20, 2022

Also encountering this. Plus, the boolean fields in the schema are listed as type: boolean but they are encoded as strings over the enum "true", "false".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants