Make Payment methods enabled
a global setting
#2432
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The configuration setting
Payment methods enabled
is shown across all scopes. No matter what scope is selected, the underlying backend modelAdyen\Payment\Model\Config\Backend\PaymentMethodsStatus
is always updating the default scope for the single payment methods.This leads to inconsistencies between
payment/adyen_abstract/payment_methods_active
and all the single payment method configurations.Payment methods enabled
toYes
inDefault
scopeWebsite A
and aWebsite B
in placePayment methods enabled
toYes
inWebsite A
scopeExpected Result
Payment methods are still active in
Website B
Actual Result
Payment methods are deactived in
Website B
as wellShowing the configuration setting only in
Default
scope won't lead to such inconsistencies.Tested scenarios
Stores > Configuration > Sales > Adyen > Accepting Payments > Payment methods > Payment methods enabled
is a global setting