Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Payment methods enabled a global setting #2432

Closed
wants to merge 2 commits into from

Conversation

aschrammel
Copy link

Description
The configuration setting Payment methods enabled is shown across all scopes. No matter what scope is selected, the underlying backend model Adyen\Payment\Model\Config\Backend\PaymentMethodsStatus is always updating the default scope for the single payment methods.
This leads to inconsistencies between payment/adyen_abstract/payment_methods_active and all the single payment method configurations.

  • Set Payment methods enabled to Yes in Default scope
  • Having a Website A and a Website B in place
  • Set Payment methods enabledto Yes in Website A scope

Expected Result
Payment methods are still active in Website B
Actual Result
Payment methods are deactived in Website B as well

Showing the configuration setting only in Default scope won't lead to such inconsistencies.

Tested scenarios
Stores > Configuration > Sales > Adyen > Accepting Payments > Payment methods > Payment methods enabled is a global setting

@aschrammel aschrammel requested a review from a team as a code owner January 10, 2024 14:18
@RokPopov
Copy link
Contributor

Hi @aschrammel,

Thank you for your efforts and contribution to improving our plugin. We appreciate the time and thought you put into your PR regarding making the configuration global.

After careful consideration, we've decided to proceed with a different approach that implements scopable configurations for payment methods. You can take a look at the PR we're moving forward with here.

We value your contributions and encourage you to continue sharing your ideas and improvements with us.

Kind regards,
Rok

@RokPopov RokPopov closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants