-
Notifications
You must be signed in to change notification settings - Fork 111
Change default item level text position #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Item level text overlaps with upgrade indicator.
|
Are you seeing the errors discussed in #174? |
|
Just checked and im getting the error when opening bank UI. |
|
I'd like to hear some more opinions on this change. Can you share a before and after screenshot? |
|
Nice Lego! I like arrow and ilvl in the same line. But i think it will not work with all the fonts (not at home to test). And what happens if we get ilvl 1000 anytime soon? |
|
The item level text uses NumberFontNormal and isn't user configurable. NumberFontNormal inherits from NumberFont_Outline_Med which looks like it might render as a different width for simplifiedchinese and traditionalchinese. 4 digit item levels will overlap with the upgrade icon. There doesn't seem to be enough room to fit both item level and the upgrade icon on the same line when item levels reach 1000. |
|
The layout looks crisp with the adjusted text location. I think the image with the arrow-icon to the right looks more fluent, as it shows ilvl first and foremost - Followed by an arrow indicating if it is in-fact an upgrade. |
|
I like the item level on the bottom left, if we're thinking ilvl 1000 is coming in WoW.8 |
|
Closed in favor of #496. |




Item level text overlaps with upgrade indicator.