Skip to content

Commit

Permalink
Default to both REPL and console printing
Browse files Browse the repository at this point in the history
Weasel by default overwrites the *print-fn* global variable to redirect
all printing to the REPL after the REPL connection has been opened. In
practice this means that if you are using boot-cljs-repl and are also
printing to the console via `(enable-console-print)`, your console printing will
work for an abritrary period of time until it doesn't anymore.

This patch configures Weasel to set the *print-fn* to print to the REPL
and the console. IMO, this is the best default to ensure that users
aren't confused when half print statements stop working. It's not at all
obvious that what the cause is and the amount of people that will be run
into this problem is large.

I'm also open to exposing this as an option for the task, if you think
that's a good idea.

Addresses this issue: adzerk-oss#26
  • Loading branch information
AdamFrey committed Jun 28, 2016
1 parent 6ce0ee1 commit 5682425
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/adzerk/boot_cljs_repl.clj
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
(:require [weasel.repl :as repl]))
(let [repl-conn ~conn]
(when (and repl-conn (not (repl/alive?)))
(repl/connect ~conn)))))
(repl/connect ~conn :print #{:repl :console})))))
(map pr-str) (interpose "\n") (apply str) (spit @out-file)))

(defn- write-repl-connect-file
Expand Down

0 comments on commit 5682425

Please sign in to comment.