Hang - Lions #103
Open
Hang - Lions #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Personal Portfolio Site
What We're Looking For
| Feature | Feedback |
|---|---|
| Baseline | |
| Appropriate Git Usage | ✅ |
| Answered comprehension questions | ✅ |
| Page fully loads | ✅ |
| No broken links (regular or images) | ✅ |
| Includes at least 3 pages and styling | ✅ |
| HTML | |
Uses the high-level tags for organization: header, footer, main |
✅ |
Appropriately using semantic tags: section, article, etc. |
✅ |
| All images include alternate text | ✅ |
| CSS | |
| Using class and ID names in style declarations | Only classes, no IDs |
| Style declarations are DRY | Mostly. It would be good to have a stylesheet used by all pages that contain properties that are the same for every page. |
| Using Flexbox and/or Grid | ✅ |
| Overall | ✅ |
| nav { | ||
| overflow: hidden; | ||
| background-color:salmon; | ||
| padding: 1.px; |
There was a problem hiding this comment.
It looks like there might be a typo here that is causing problems with the rest of the styling?
| /> | ||
| <img | ||
| src = "../assets/image/cooking.jpeg" | ||
| alt = "cooking" |
There was a problem hiding this comment.
It would be great if the alt text for the images were more descriptive. For someone with low vision/blindness, they depend on screen readers to tell them what the picture is. For example, this picture will just be called "cooking", which doesn't capture the beautiful dish you've created.
Comment on lines
+81
to
+95
| .fa-linkedin { | ||
| background: black; | ||
| color: white; | ||
| } | ||
|
|
||
|
|
||
| .fa-instagram { | ||
| background: black; | ||
| color: white; | ||
| } | ||
|
|
||
| .fa-github { | ||
| background: black; | ||
| color:white | ||
| } |
There was a problem hiding this comment.
Since these all have the same property, you can do
.fa:hover, .fa-instagram, .fa-github {
}
or give all of these elements the same class name instead of three separate ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions
I deleted a Meta tag built in, changed some tags (such as section to div so I don’t need a header section), and removed unclosed tags I accidentally forgot to remove.
Why is it important to consider and use semantic HTML? |
It’s important to use semantic html to define different sections and layout of web pages. It’s more readable and easier to maintain.
How did you decide to structure your CSS? |
My CSS is structure to different files in a folder and each file has a relationship to the different pages. While I may avoid repeating myself in certain cases, such as having the footer in the center for all pages, I thought it would cleaner to have it in separate spaces. I also have it in order of the structure of the page layout, so header css on top, and footer on bottom.
What was the most challenging piece of this assignment? |
The most challenging piece of this assignment for me was having the layout the way I want, including using grid/flex.
Describe one area that you gained more clarity on when completing this assignment |
I gained a lot more clarity on using flex and grid to get the desired layout.
Optional |
Did you deploy to GitHub Pages? If so, what is the URL to your website? |
https://hangmtran.github.io/portfolio-site/index.html