Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final version of JS adagrams-Diana S. #133

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

sorindevops
Copy link

No description provided.

Copy link

@marciaga marciaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with this one! Specific feedback on lines below.

@@ -0,0 +1,17 @@
{
// Use IntelliSense to learn about possible attributes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably break some aspects of VSCode. JSON format does not support comments like in JavaScript.

export const drawLetters = () => {
// Implement this method for wave 1
const thisHand = [];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with this function!

@@ -120,7 +120,7 @@ describe("Adagrams", () => {
});

it("returns a score of 0 if given an empty input", () => {
throw "Complete test";
expect(scoreWord("")).toBe(0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍🏽

@@ -145,7 +145,7 @@ describe("Adagrams", () => {
const words = ["XXX", "XXXX", "X", "XX"];
const correct = { word: "XXXX", score: scoreWord("XXXX") };

throw "Complete test by adding an assertion";
expect(highestScoreFrom(words)).toEqual(correct);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants