Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Touch Target Minimum sections to Links and Button pages #391

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Jan 27, 2024

Describe your changes

This is an improved version of PR #390. Read the Description section for context.

Screenshots - If Any (Optional)

Link to issue

Closes #386

Checklist before requesting a review

  • I have performed a self-review of my code.
  • Followed the repository's Contributing Guidelines.
  • I ran the app and tested it locally to verify that it works as expected.
  • I have checked my code with an automatic accessibility tool such as Axe Dev Tools or Wave
    and it shows no errors.

Additional Information (Optional)

N/A

Copy link
Member

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks good. Are you able to move the text up so it's above the WCAG criteria section in both cases? If not, let me know and I'll fix it on my side.

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 3, 2024

The text looks good. Are you able to move the text up so it's above the WCAG criteria section in both cases? If not, let me know and I'll fix it on my side.

Hey @EmmaDawsonDev. No, it'll be harder to do on the app

@EmmaDawsonDev
Copy link
Member

No worries, I can merge it in and fix it.

@EmmaDawsonDev EmmaDawsonDev merged commit ab8c914 into AccessibleForAll:main Feb 3, 2024
2 checks passed
@CBID2 CBID2 deleted the adding-new-section branch February 3, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add section about minimum touch target size to buttons and links
2 participants