Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: links not opening at all #86

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

back2Lobby
Copy link
Contributor

@back2Lobby back2Lobby commented Nov 10, 2024

Description

No link was opening in the app. This pr adds the tauri shell plugin that will allow the app to open links in the default browser. There wasn't any code changes by me manually, all I did is run command npm run tauri add shell to add the plugin. It modified all the files itself and here we are.

Fixes # (issue)
#85

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Idk, it wasn't opening any links for me on my ubuntu 24. Now it does open perfectly ;D

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules (idk what this means)

@Abdenasser
Copy link
Owner

thank you for taking time to fix that, really appreciate it.. let's not reformat everything.. It will be nice to only see the diff of the code responsible of opening the update.

Copy link
Owner

@Abdenasser Abdenasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please address my first comment.

@Abdenasser Abdenasser merged commit f73fa7a into Abdenasser:main Nov 10, 2024
2 checks passed
@back2Lobby
Copy link
Contributor Author

Man you are super fast, I was just stuck in the git related things, sorry for that 😅

@back2Lobby back2Lobby deleted the fix/opening-links branch November 10, 2024 13:41
@Abdenasser
Copy link
Owner

Man you are super fast, I was just stuck in the git related things, sorry for that 😅

no worried man, and thanks a lot for fixing that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants