Bugfix/128 force action desat reset #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark2000
reviewed
Apr 23, 2024
| @@ -126,7 +129,7 @@ def __init__( | |||
| super().__init__(*args, **kwargs) | |||
| setattr(self, fsw_action + "_duration", action_duration) | |||
|
|
|||
| def act(self, prev_action_key=None) -> str: | |||
| def act(self, prev_action_key=None, always_reset=always_reset) -> str: | |||
There was a problem hiding this comment.
Does always_reset need to be an argument here?
There was a problem hiding this comment.
It doesn't. I agree that it is better to remove it from there.
| env.step(0) | ||
| current_speeds = env.satellite.dynamics.wheel_speeds | ||
| assert np.linalg.norm(current_speeds) < np.linalg.norm(init_speeds) | ||
| init_speeds = current_speeds |
LorenzzoQM
force-pushed
the
bugfix/128_force_action_desat_reset
branch
from
fb0e04f to
00fd0cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #128
Action_desat was not reducing reaction wheels' momentum if called more than once in a row. This change forces a reset of the action_desat every time it is tasked, resulting in the expected behavior.
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Passes Tests
pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/unittestpytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/integrationpytest tests/examplesTest Configuration
Checklist:
Issue #XXX: Messageand have a useful message