Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute name for active class in init_page.js #941

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthewbbrandt
Copy link

When adding styles to a sort nav, the active nav element can be selected using .components--sort-nav a[className="js-selected"]. However, it seems the intention is to make a class attribute so that the active element can be selected with .components--sort-nav a.js-selected.

Other notes

  • I did not investigate any downstream impacts.
  • Assigning a className attribute also occurs in jinja2/user_profile/user_edit.html. This might also be worth reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant