ios fix (#466) applied manually to existing DeviceOrientationControls #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nickw1 i will check and test the code when i will have a bit of time. 🙂 |
kalwalt
added
bug
|
Hi @kalwalt many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes iOS device orientation issues for location-based AR.
Can it be referenced to an Issue? If so what is the issue # ?
466
How can we test it?
Test the
location-basedexamples within the A-Frame examples directory, particularlybasic-js.Summary
Fix was made primarily by @json91-dev. I applied it to the existing repo. Please see #466 for more details.
Does this PR introduce a breaking change?
No
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Personally tested in Chrome on Android 10. Others have tested on iOS. Please see #466
Other information
@kalwalt can you check this? Thanks.