Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#260047 event participation #417

Merged
merged 64 commits into from
Feb 7, 2024

Conversation

MalibusParty
Copy link
Collaborator

  • created api endpoints for events (create, delete, edit, join, leave, ...) and event invitations
  • added view and components for event admin area
  • added event input to week planning
  • added event row to days on the dashboard
  • created Mercure message to notify on joining/leaving an event
  • added a participants list for events
  • extended the printList view with a print function
  • added tests for all things related to events

Simon Henz and others added 30 commits February 1, 2024 10:28
@MalibusParty MalibusParty requested a review from hacksch February 1, 2024 10:44
{
public function __construct(
EventParticipationService $eventPartSrv,
GuestParticipationService $gps,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

die Benamung von $gps würde ich dem eventPartSrv anpassen also GuestPartSrv

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ist erledigt

@@ -104,7 +104,7 @@ private function slotIsAvailable(Slot $slot, DateTime $date): bool
*/
private function createParticipation(Profile $profile, Meal $meal, ?Slot $slot = null, array $dishSlugs = []): Participant
{
$participant = new Participant($profile, $meal);
$participant = new Participant($profile, $meal, null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dritter parameter ist unnötig, siehe

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ist entfernt

@@ -15,6 +15,8 @@ import MenuParticipations from './views/MenuParticipations.vue';
import CostsSettlement from './views/CostsSettlement.vue';
import CashRegister from './views/CashRegister.vue';
import Login from '@/views/Login.vue';
import Events from './views/Events.vue';
import GuestEvent from './views/GuestEvent.vue';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zuviele leerzeichen vor dem "from"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auf eines reduziert


const EventsState = reactive<EventsState>({
events: [],
error: "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single quotes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wurde ausgebessert

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

die Datei scheint noch im Repo zu sein, wurde aber in der ignore ausgeklammert, müsste noch gelöscht werden

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wurde gelöscht

@@ -0,0 +1,36 @@
import useApi from '@/api/api';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inkonsistent, hier single quotes, in anderen dateien double quotes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wurde durch double quotes ersetzt

@@ -0,0 +1,153 @@
import useApi from '@/api/api';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inkonsistent, hier single quotes, in anderen dateien double quotes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wurde durch double quotes ersetzt

@MalibusParty MalibusParty merged commit 97835bd into meals-beta Feb 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants