This repository was archived by the owner on Sep 22, 2025. It is now read-only.
Issue #43 #58
Open
Issue #43 #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnijhara
suggested changes
Feb 14, 2022
Collaborator
pnijhara
left a comment
pnijhara
left a comment
There was a problem hiding this comment.
Also, rename the file. Make it something meaningful.
Like index.test.js
Comment on lines
+27
to
+31
| // try { | ||
| // chai.expect(res.statusCode).to.deep.equal(200); | ||
| // } catch (e) { | ||
| // throw(e) | ||
| // } |
Collaborator
There was a problem hiding this comment.
not a good practice to keep commented code.
| // request(app) | ||
| chai.request(app) | ||
| .post('/register') | ||
| .send({ 'username': 'fasf', 'password':'fdsaf' }) |
Collaborator
There was a problem hiding this comment.
use meaningful examples like 'mock-username'.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I solved issue #43 by writing some tests with the Mocha and Chai framework in javascript.
I hope you could extend it and make them more.
I am eagerly waiting for you to merge my pull request and accept it.
Thanks a lot.
Sina Elahimanesh