amrex::FileStream #4550
Draft
amrex::FileStream #4550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tries to fix the following error reported by @BenWibking Writing checkpoint chk02500 amrex::UtilCreateDirectory:: path errno: chk02500 :: File exists amrex::UtilCreateDirectory:: path errno: chk02500/Level_2 :: Input/output error amrex::Error::0::Couldn't create directory: chk02500/Level_2 !!!
Implement our own file stream class that is somewhat similar to std::fstream. It can be used by amrex::NFilesIter in mesh and particle data I/O. By default amrex::NFilesIter still uses std::fstream. To use amrex::FileStream, one needs to use `USE_OWN_FILE_STREAM=TRUE` for GNU Make and `AMReX_OWN_FILE_STREAM=ON` for CMake. amrex::FileStream::Read has not been tested and currently it is not being used for reading MultiFab and particles.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
BenWibking
reviewed
Jul 4, 2025
| throw std::runtime_error("FileStream::write: bad file descriptor or bad state"); | ||
| } | ||
|
|
||
| if (m_buffer_mode == BufferMode::Read) { |
There was a problem hiding this comment.
From a quick skim of the code, I don't really understand the motivation for BufferMode or how it works. Is there a reason to have separate modes implemented by the same function, or can different modes have separate implementations in separate functions? I can go back and read it more carefully with more context.
There was a problem hiding this comment.
Currently we only need to open a stream for either write or read, but not both. If we want to support both, we will need to know the current mode of the buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement our own file stream class that is somewhat similar to std::fstream. It can be used by amrex::NFilesIter in mesh and particle data I/O. By default amrex::NFilesIter still uses std::fstream. To use amrex::FileStream, one needs to use
USE_OWN_FILE_STREAM=TRUEfor GNU Make andAMReX_OWN_FILE_STREAM=ONfor CMake.amrex::FileStream::Read has not been tested and currently it is not being used for reading MultiFab and particles.