Skip to content

Use geometric grow for resize in RedistributeGPU #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

AlexanderSinn
Copy link
Member

Summary

In an attempt to help with #4531 I used the resize_geometric_grow function from #4529 to resize the particle tiles in RedistributeGPU. Additionally, this PR changes the default amrex.vector_growth_factor from 1.5 to 1.25.

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@AlexanderSinn
Copy link
Member Author

I tested this on LUMI and it does not fix the problem

@AlexanderSinn
Copy link
Member Author

This does not fix the problem on its own; however, when combining this with a properly sized arane init size and disabling periodic particle sorting (which reallocates some of the particle vectors), the issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant