Adding templating to the MFInterp functions #4328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
reviewed
Feb 11, 2025
| void mf_cell_cons_lin_interp_limit_minmax_llslope (int i, int, int, Array4<Real> const& slope, | ||
| Array4<Real const> const& u, int scomp, int ncomp, | ||
| void mf_cell_cons_lin_interp_limit_minmax_llslope (int i, int, int, Array4<T> const& slope, | ||
| Array4<T const> const& u, int scomp, int ncomp, | ||
| Box const& domain, IntVect const& ratio, BCRec const* bc) noexcept | ||
| { | ||
| Real sfx = Real(1.0); |
There was a problem hiding this comment.
Should we use T here and other places in this function too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding templating to the MFInterp functions.
Additional background
This enables codes that use BaseFab (instead of MultiFabs) to use the MFInterp methods.
Checklist
The proposed changes: