Refactor - Transaction Constructor Types #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P2SH doesn't work yet, I don't want it to exist at all for the time being
…or-types # Conflicts: # src/primitives/transaction.rs # src/utils/script_utils.rs # src/utils/transaction_utils.rs
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR depends on #56 (
tx-constructor), #44 (disable-p2sh), and #51 (no-address-version).This removes the
TxConstructorstruct and replaces it with an enum containing all information necessary to construct each kind of transaction input.This is advantageous not only because it forces API users to provide all necessary information upfront (and indirectly forces inputs to be valid, since), but also because it eliminates the need for intermediate
TxInvalues with invalid contents.Changelog
TxInConstructorwith variants for each type of transaction inputTxConstructorstruct and replace all usages of it withTxInConstructorkey_materialBTreeMapwhich was used by many functions related to transaction creation; it's now redundant because all relevant information is present inTxInConstructorType of Change
Please mark the appropriate option by putting an "x" inside the brackets:
Checklist
Put an "x" in the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!
Screenshots (if applicable)
If the changes affect the UI or have visual effects, please provide screenshots or GIFs showcasing the changes.
Additional Context (if applicable)
Add any additional context or information about the changes that may be helpful in understanding the pull request.
Related Issues (if applicable)
If this pull request is related to any existing issues, please list them here.
Requested Reviewers
Mention any specific individuals or teams you would like to request a review from.