-
Notifications
You must be signed in to change notification settings - Fork 351
[WIP - no merge] Update add label based on code owners #1772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Just a note to myself/readers, took some time for me to figure out - This PR relies on the per - file owners being added to required owners via your per-owner PR - #1690? We have this key conditional
This isn't perfect - for instance if someone writes a PR that touches both moe.py and pipeline.py and I approve it, it will get pull ready since I own pipeline.py despite the fact that no moe.py owners reviewed. |
Yes. That's my concern in my PR description note. Running some manual tests with my current change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RissyRan asked me to add my approval to test the workflow. I am not the owner of this file, so we want to see if the Pull Ready
label is added. I can take another look once things are ready if needed
Description
Update the add label file based on recent code owner change: PR
Tests
N/A
Checklist
Before submitting this PR, please make sure (put X in square brackets):