Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using led settings also for led_hermetic_tpc #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

using led settings also for led_hermetic_tpc #9

wants to merge 1 commit into from

Conversation

juliadierle
Copy link

No description provided.

@juliadierle juliadierle requested a review from adambrown1 April 7, 2021 07:53
adambrown1
adambrown1 approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@adambrown1 adambrown1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I wonder if we could put the strax target into the DAQ configuration document somehow, but probably the more pragmatic solution is to just add an extra run mode to this list each time we build a new TPC ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambrown1 adambrown1 adambrown1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliadierle @adambrown1