-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StatsD monitor #2969
Add StatsD monitor #2969
Conversation
Nice! Do we still want to keep the prometheus monitor, then? Don't they solve similar problems? |
In my understanding, prometheus monitor is used to view detailed statistics about one fuzzing instance (with multiple clients maybe), since it can show the statistics about individual clients. The statsd is used to view aggregated statistics about multiple fuzzing instances (showing individual client statistics will make the visualized graph very distracting). |
Are there any conversations not resolved? Should we merge this PR? |
Thank you! |
@@ -206,6 +206,7 @@ impl ClientStatsManager { | |||
} | |||
|
|||
/// Get item geometry | |||
#[allow(clippy::cast_precision_loss)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this should be expect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will create a PR quickly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds a
StatsdMonitor
, which is roughly a counterpart of AFL++'s rpc_statsd.There are two more things could be done after this PR:
libafl/src/monitors/statsd.rs
, there are several metrics currently not available, which is available in AFL++. Some of these metrics could be resolved inAflStatsStage
. This stage involves much with the Monitor's statistics, so we should think more about this (and maybe some refactors to make this more maintainable). (In my first thought, shouldn't it be Monitor's responsibility to write tofuzzer_stats
andplot_data
?)This PR also solves #2895.