Merged
Conversation
domenukk
reviewed
Feb 12, 2025
domenukk
reviewed
Feb 12, 2025
domenukk
reviewed
Feb 12, 2025
domenukk
reviewed
Feb 12, 2025
domenukk
reviewed
Feb 12, 2025
domenukk
reviewed
Feb 12, 2025
domenukk
reviewed
Feb 12, 2025
Member
|
Nice! Do we still want to keep the prometheus monitor, then? Don't they solve similar problems? |
Contributor
Author
|
In my understanding, prometheus monitor is used to view detailed statistics about one fuzzing instance (with multiple clients maybe), since it can show the statistics about individual clients. The statsd is used to view aggregated statistics about multiple fuzzing instances (showing individual client statistics will make the visualized graph very distracting). |
Contributor
Author
|
Are there any conversations not resolved? Should we merge this PR? |
Member
|
Thank you! |
domenukk
reviewed
Feb 13, 2025
| } | ||
|
|
||
| /// Get item geometry | ||
| #[allow(clippy::cast_precision_loss)] |
Contributor
Author
There was a problem hiding this comment.
I will create a PR quickly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
StatsdMonitor, which is roughly a counterpart of AFL++'s rpc_statsd.There are two more things could be done after this PR:
libafl/src/monitors/statsd.rs, there are several metrics currently not available, which is available in AFL++. Some of these metrics could be resolved inAflStatsStage. This stage involves much with the Monitor's statistics, so we should think more about this (and maybe some refactors to make this more maintainable). (In my first thought, shouldn't it be Monitor's responsibility to write tofuzzer_statsandplot_data?)This PR also solves #2895.