refactor: only include "required by modules" suffix for checks that are module-specific #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Etienne-Buschong
approved these changes
Sep 13, 2024
…re module-specific As soon as a module includes a field or type, it includes all of its specialities. Checks like whether the type match are independent of the module selection. For this reason, it is noisy and confusing to include the list of modules in the messages.
Yogu
force-pushed
the
remove-required-by-modules-suffixes
branch
from
5e5635c to
919dee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As soon as a module includes a field or type, it includes all of its specialities. Checks like whether the type match are independent of the module selection. For this reason, it is noisy and confusing to include the list of modules in the messages.