Fixes for dict-based child entity update implementation #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add new child entities Previously, we did not check whether the child entities we wanted to update actually existed. The bug has been introduced with the new dict-based child entity update implementation.
…rrently were no child entities When the dict-based child entity impelemntation was used, and an non-empty update... for child entity was given, and this child entity list for the updated root entity was currently empty, and AQL error was generated. The problem was that we used a range generator that should have generated an empty range, but the AQL ranges are never empty, they just are inverted if the end position is lower than the start position. This resulted in an invalid ZIP call, which yielded NULL.
Yogu
force-pushed
the
child-entity-update-fixes
branch
from
6998654 to
d4439e9
Compare
mfusser
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.