fix: correct wrong errors and error codes for query/mutation list limit

AEB-labs · Jan 9, 2025 · db982e3 · db982e3
1 parent 0d03120
commit db982e3
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/spec/authorization/move-errors-to-output-nodes.spec.ts b/spec/authorization/move-errors-to-output-nodes.spec.ts
@@ -3,16 +3,15 @@ import { moveErrorsToOutputNodes } from '../../src/authorization/move-errors-to-
 import {
     ConditionalQueryNode,
     ConstBoolQueryNode,
+    FLEX_SEARCH_TOO_MANY_OBJECTS,
     ListQueryNode,
     ObjectQueryNode,
     PreExecQueryParms,
     PropertySpecification,
-    FLEX_SEARCH_TOO_MANY_OBJECTS,
     RuntimeErrorQueryNode,
     TransformListQueryNode,
     WithPreExecutionQueryNode,
 } from '../../src/query-tree';
-import { TOO_MANY_OBJECTS_ERROR } from '../../src/schema-generation/flex-search-generator';
 
 describe('move-errors-to-output-nodes', () => {
     it('moves errors in filter up', () => {
@@ -153,10 +152,10 @@ describe('move-errors-to-output-nodes', () => {
                 new WithPreExecutionQueryNode({
                     resultNode: new ConditionalQueryNode(
                         new ConstBoolQueryNode(true),
-                        new RuntimeErrorQueryNode(TOO_MANY_OBJECTS_ERROR, {
+                        new RuntimeErrorQueryNode('Too many objects.', {
                             code: FLEX_SEARCH_TOO_MANY_OBJECTS,
                         }),
-                        new RuntimeErrorQueryNode(TOO_MANY_OBJECTS_ERROR, {
+                        new RuntimeErrorQueryNode('Too many objects.', {
                             code: FLEX_SEARCH_TOO_MANY_OBJECTS,
                         }),
                     ),

diff --git a/src/query-tree/errors.ts b/src/query-tree/errors.ts
@@ -38,6 +38,7 @@ export const FLEX_SEARCH_TOO_MANY_OBJECTS = 'FLEX_SEARCH_TOO_MANY_OBJECTS';
 export const BILLING_KEY_FIELD_NOT_FILLED_ERROR = 'BILLING_KEY_FIELD_NOT_FILLED';
 export const NOT_SUPPORTED_ERROR = 'NOT_SUPPORTED';
 export const ARGUMENT_OUT_OF_RANGE_ERROR = 'ARGUMENT_OUT_OF_RANGE';
+export const TOO_MANY_OBJECTS_ERROR = 'TOO_MANY_OBJECTS';
 
 export const RUNTIME_ERROR_TOKEN = '__cruddl_runtime_error';
 export const RUNTIME_ERROR_CODE_PROPERTY = '__cruddl_runtime_error_code';

diff --git a/src/query-tree/validation.ts b/src/query-tree/validation.ts
@@ -1,6 +1,6 @@
 import { RelationSide, RootEntityType } from '../model';
-import { TOO_MANY_OBJECTS_ERROR } from './../schema-generation/flex-search-generator';
 import { QueryNode } from './base';
+import { TOO_MANY_OBJECTS_ERROR } from './errors';
 
 export interface QueryResultValidatorFunctionProvider {
     /**

diff --git a/src/schema-generation/flex-search-generator.ts b/src/schema-generation/flex-search-generator.ts
@@ -51,7 +51,6 @@ import { orderArgMatchesPrimarySort } from './utils/flex-search-utils';
 import { or } from './utils/input-types';
 
 export const DEFAULT_FLEXSEARCH_MAX_FILTERABLE_AMOUNT: number = 1000;
-export const TOO_MANY_OBJECTS_ERROR = 'Too many objects.';
 
 /**
  * Augments list fields with filter and pagination features
@@ -243,7 +242,7 @@ export class FlexSearchGenerator {
                         ],
                         resultNode: new ConditionalQueryNode(
                             assertionVariable,
-                            new RuntimeErrorQueryNode(TOO_MANY_OBJECTS_ERROR, {
+                            new RuntimeErrorQueryNode('Too many objects.', {
                                 code: FLEX_SEARCH_TOO_MANY_OBJECTS,
                             }),
                             sourceNode,

diff --git a/src/schema-generation/order-by-and-pagination-augmentation.ts b/src/schema-generation/order-by-and-pagination-augmentation.ts
@@ -16,6 +16,7 @@ import {
     OrderSpecification,
     PreExecQueryParms,
     QueryNode,
+    RuntimeError,
     RuntimeErrorQueryNode,
     TransformListQueryNode,
     VariableQueryNode,
@@ -120,7 +121,7 @@ export class OrderByAndPaginationAugmentation {
                     executionOptions.implicitLimitForRootEntityQueries &&
                     data.length > executionOptions.implicitLimitForRootEntityQueries
                 ) {
-                    throw new Error(
+                    throw new RuntimeError(
                         `Collection is truncated by default to ${executionOptions.implicitLimitForRootEntityQueries} elements but contains more elements than this limit. Specify a limit manually to retrieve all elements of the collection.`,
                     );
                 }