-
Notifications
You must be signed in to change notification settings - Fork 0
Update gh SPR #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gh SPR #23
Conversation
|
The CI failure is a style check on a package I didn't touch. I feel no responsibility to fix it. |
CodeGat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I also validated that [email protected]: exists in spack v0.22, which it does
|
I'm just running an install test on |
|
Worked fine |
|
Hi @aidanheerdegen & @CodeGat , Please replace the Spack upstream PR number with this PR number in the cherry-picked commits' subject line. Also, please add the original Spack upstream commit hash in the commit message. |
* Cherry-picked upstream commit 5e363bd
* Cherry-picked upstream commit 32dfb52
* cherry-picked 32dfb52
* cherry picked d4a7582
* cherry-picked 32dfb52
* cherry picked d4a7582
Cherry pick commits to update
ghspack package so a new version can be deployed for this ACCESS-NRI/system-tools#17Only two versions were cherry-picked, as there was a change to a
gobuilder, that was later reverted. Looked messy, so avoided that as it wasn't required for this use case.Looked into updating some of the other SPRs referenced in the PR above, but
ncduhad no updates,opensshhad already been updated, andpinentryseemed kinda niche, so didn't do anything with that.