Skip to content

Conversation

@aidanheerdegen
Copy link
Member

Cherry pick commits to update gh spack package so a new version can be deployed for this ACCESS-NRI/system-tools#17

Only two versions were cherry-picked, as there was a change to a go builder, that was later reverted. Looked messy, so avoided that as it wasn't required for this use case.

Looked into updating some of the other SPRs referenced in the PR above, but ncdu had no updates, openssh had already been updated, and pinentry seemed kinda niche, so didn't do anything with that.

@aidanheerdegen
Copy link
Member Author

The CI failure is a style check on a package I didn't touch. I feel no responsibility to fix it.

Copy link
Member

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I also validated that [email protected]: exists in spack v0.22, which it does

@aidanheerdegen
Copy link
Member Author

I'm just running an install test on gadi to confirm it works. Will paste the result in here when it is finished and assuming all is well will merge.

@aidanheerdegen
Copy link
Member Author

Worked fine

==> Installing gh-2.49.2-75vocsbolvqmv52nopp6oyaapkw7v3gl [41/41]
==> No binary for gh-2.49.2-75vocsbolvqmv52nopp6oyaapkw7v3gl found: installing from source
==> Fetching https://mirror.spack.io/_source-cache/archive/e8/e839ea302ad99b70ce3efcb903f938ecbbb919798e49bc2f2034ad506ae0b0f5.tar.gz
==> No patches needed for gh
==> gh: Executing phase: 'build'
==> gh: Executing phase: 'install'
==> gh: Successfully installed gh-2.49.2-75vocsbolvqmv52nopp6oyaapkw7v3gl
  Stage: 2.17s.  Build: 46.76s.  Install: 26.82s.  Post-install: 1.41s.  Total: 1m 18.44s
[+] /.../spack/0.22/release/linux-rocky8-x86_64_v4/gcc-14.1.0/gh-2.49.2-75vocsbolvqmv52nopp6oyaapkw7v3gl

@aidanheerdegen aidanheerdegen merged commit f92f4c0 into releases/v0.22 Dec 10, 2025
10 of 11 checks passed
@github-project-automation github-project-automation bot moved this to Done ✅ in Model Release Dec 14, 2025
@harshula
Copy link
Collaborator

harshula commented Dec 14, 2025

Hi @aidanheerdegen & @CodeGat , Please replace the Spack upstream PR number with this PR number in the cherry-picked commits' subject line. Also, please add the original Spack upstream commit hash in the commit message.

aidanheerdegen pushed a commit that referenced this pull request Dec 14, 2025
* Cherry-picked upstream commit 5e363bd
aidanheerdegen pushed a commit that referenced this pull request Dec 14, 2025
* Cherry-picked upstream commit 32dfb52
aidanheerdegen pushed a commit that referenced this pull request Dec 15, 2025
aidanheerdegen pushed a commit that referenced this pull request Dec 15, 2025
aidanheerdegen pushed a commit that referenced this pull request Dec 15, 2025
aidanheerdegen pushed a commit that referenced this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done ✅

Development

Successfully merging this pull request may close these issues.

5 participants