Omit unset ranges for TextDocumentContentChangeEvent #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Typescript language server [checks ranges only for equality to `undefined`](https://github.com/microsoft/vscode-languageserver-node/blob/1ce790dd341a38da1fbf902cddc16ce456149de0/protocol/src/common/protocol.ts#L1915) to determine if a change is incremental. This means that unset ranges need to be omitted completely from the generated messages instead of encoding them as `null`. Fixes 9fans/acme-lsp#75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Typescript language server checks ranges only for equality to
undefinedto determine if a change is incremental.This means that unset ranges need to be omitted completely from the generated messages instead of encoding them as
nullto avoid the Typescript LSP (and possibly others reusing the VSCode LSP code) tripping over range elements being unset, and thus not updating its internal view of text documents whenacme-lsphandles a Put.Fixes 9fans/acme-lsp#75