Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first completion target with multiple matches #59

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

farhaven
Copy link
Contributor

@farhaven farhaven commented Jul 5, 2023

When a completion target has multiple matches, such as when editing Go code that uses generated Protobuf packages that have the same method name at multiple levels of hierarchy, insert the first match always, and display the rest in an Acme window called /LSP/Completions similar to /LSP/Diagnostics.

This behaviour can be triggered by passing -E to L comp instead of -e. The existing behaviour for -e is preserved as is.

Closes #56

When a completion target has multiple matches, such as when editing Go code that uses generated Protobuf packages that have the same method name at multiple levels of hierarchy, insert the first match always, and display the rest in an Acme window called `/LSP/Completions` similar to `/LSP/Diagnostics`.

This behaviour can be triggered by passing `-E` to `L comp` instead of `-e`. The existing behaviour for `-e` is preserved as is.
Copy link
Collaborator

@fhs fhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fhs fhs merged commit c6ffdf3 into 9fans:master Jul 9, 2023
2 checks passed
@farhaven farhaven deleted the completion-window branch July 10, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always insert first suggestion in L comp -e
2 participants