set_global returns name of variable instead True

813gan · Aug 15, 2024 · ee024f1 · ee024f1
1 parent 25f5af2
commit ee024f1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/subinterpreter.c b/subinterpreter.c
@@ -269,7 +269,7 @@ PyObject *set_global(char *interpreter_name, PyObject *obj, PyObject *as) {
  SUBINTERPRETER_SWITCH;
  PyObject_SetItem(global_dict, as, obj);
  PyObject *exception = PyErr_GetRaisedException();
- PyObject *ret = Py_True;
+ PyObject *ret = Py_NewRef(as);
 
  SUBINTERPRETER_RETURN;
 }
diff --git a/tests/test.el b/tests/test.el
@@ -45,7 +45,7 @@
  :type 'python-exception) )
 
 (ert-deftest ert-test-emacspy-py-set-global ()
- (should (py-set-global "test" "test_value" "test_str"))
+ (should (string= "test_str" (py-set-global "test" "test_value" "test_str")))
  (should (string= "test_value" (py-get-global-variable "test" "test_str"))) )
 
 (ert-deftest ert-test-emacspy-import-custom-module ()
@@ -64,9 +64,9 @@
  (load "emacspy"))))
 
 (ert-deftest ert-test-emacspy-data-int ()
- (should (py-set-global "test" 1 "test_int"))
- (should (eq 1 (py-get-global-variable "test" "test_int")))
- (should (py-set-global "test" -1 "test_int"))
- (should (eq -1 (py-get-global-variable "test" "test_int")))
- (should (py-set-global "test" 0 "test_int"))
- (should (eq 0 (py-get-global-variable "test" "test_int"))) )
+ (should (eq 1 (py-get-global-variable
+  "test" (py-set-global "test" 1 "test_int"))))
+ (should (eq -1 (py-get-global-variable
+  "test" (py-set-global "test" -1 "test_int"))))
+ (should (eq 0 (py-get-global-variable
+  "test" (py-set-global "test" 0 "test_int")))) )