fix RuntimeError: dictionary changed size during iteration

51bitquant · Oct 11, 2021 · 3549375 · 3549375
1 parent afcd660
commit 3549375
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/trader/binance_future_trader.py b/trader/binance_future_trader.py
@@ -208,7 +208,7 @@ def start(self):
             return
 
         symbols = self.positions.positions.keys()
-
+        deleted_positions = []
         for s in symbols:
             pos_data = self.positions.positions.get(s)
             pos = pos_data.get('pos')
@@ -221,7 +221,8 @@ def start(self):
                 value = pos * bid_price
                 if value < self.symbols_dict.get(s, {}).get('min_notional', 0):
                     print(f"{s} notional value is small, delete the position data.")
-                    del self.positions.positions[s]  # delete the position data if the position notional is very small.
+                    deleted_positions.append(s)
+                    # del self.positions.positions[s]  # delete the position data if the position notional is very small.
                 else:
                     avg_price = pos_data.get('avg_price')
                     self.positions.update_profit_max_price(s, bid_price)
@@ -288,6 +289,9 @@ def start(self):
             else:
                 print(f"{s}: bid_price: {bid_price}, ask_price: {bid_price}")
 
+        for s in deleted_positions:
+            del self.positions.positions[s]  # delete the position data if the position notional is very small.
+
         pos_symbols = self.positions.positions.keys()  # the position's symbols, if there is {"symbol": postiondata}, you get the symbols here.
         pos_count = len(pos_symbols)  # position count
 

diff --git a/trader/binance_spot_trader.py b/trader/binance_spot_trader.py
@@ -218,6 +218,7 @@ def start(self):
 
         symbols = self.positions.positions.keys()
 
+        deleted_positions = []
         for s in symbols:
             pos_data = self.positions.positions.get(s)
             pos = pos_data.get('pos')
@@ -230,7 +231,8 @@ def start(self):
                 value = pos * bid_price
                 if value < self.symbols_dict.get(s, {}).get('min_notional', 0):
                     print(f"{s} notional value is small, delete the position data.")
-                    del self.positions.positions[s]  # delete the position data if the position notional is very small.
+                    deleted_positions.append(s) #
+                    # del self.positions.positions[s]  # delete the position data if the position notional is very small.
                 else:
                     avg_price = pos_data.get('avg_price')
                     self.positions.update_profit_max_price(s, bid_price)
@@ -297,6 +299,9 @@ def start(self):
             else:
                 print(f"{s}: bid_price: {bid_price}, ask_price: {bid_price}")
 
+        for s in deleted_positions:
+            del self.positions.positions[s]  # delete the position data if the position notional is very small.
+
         pos_symbols = self.positions.positions.keys()  # 有仓位的交易对信息.
         pos_count = len(pos_symbols)  # 仓位的个数.