-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async loading and cancellation tokens in CloudRequestEngine
#137
Closed
drasmart
wants to merge
76
commits into
51Degrees:version/4.5
from
postindustria-tech:cancellation-tokens-4.5
Closed
Async loading and cancellation tokens in CloudRequestEngine
#137
drasmart
wants to merge
76
commits into
51Degrees:version/4.5
from
postindustria-tech:cancellation-tokens-4.5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # FiftyOne.Pipeline.CloudRequestEngine/FlowElements/CloudRequestEngine.cs
…sultService`. pt.2
…all `IFlowData.Process(CancellationToken)` now.
…lways consumed by at least one task (i.e. never bubble up to the worker).
…lways consumed by at least one task (i.e. never bubble up to the worker). pt.2
…lways consumed by at least one task (i.e. never bubble up to the worker). pt.3
…lways consumed by at least one task (i.e. never bubble up to the worker). pt.4
…le.GetValueAsync`.
…ineResultService`.
…<string, string>`.
…nstructors to getter.
…<string, string>`. pt.2
Decided to possibly postpone to version 5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 Expands on #134
For the content delta see:
CloudRequestEngine
(new for 4.5) postindustria-tech/pipeline-dotnet#5Changes
TaskWaitingCancellation/TaskExtensions
static class -- providesTask<T> WithCancellation<T>(this Task<T>, CancellationToken)
extension method:AsyncLazyFailable
:Task<TResult> GetValueAsync(CancellationToken)
method.AggregateException
).CloudRequestEngine
:AsyncLazyFailable
.EvidenceKeyFilter
,PublicProperties
) at constructor time.IFlowData.ProcessingCancellationToken
to [HttpClient.SendAsync].IFlowData
interface:void Process(CancellationToken)
method -- allows the caller to cancel the operation.FlowData
class --Process()
now forwards toProcess(CancellationToken)
successor implementation.CancellationToken ProcessingCancellationToken { get; }
property -- exposes the provided [CancellationToken] to pipeline and flow elements.Pipeline.Process(IFlowData)
andFlowData.Process(CancellationToken)
now respectProcessingCancellationToken
and can throw [OperationCanceledException].WebPipeline
(for ASP.NET Framework) passes the tokens from [HttpContextBase] forIFlowData.Process
:PipelineResultService
(for ASP.NET Core) passes [HttpContext.RequestAborted] toIFlowData.Process
.CloudRequestException
:responseHeaders
inIReadOnlyDictionary<string, string>
form -- as returned byResponseHeaders
property -- to allow re-constructing the exception fromAggregateException
's inner cause.ResponseHeaders
from constructors lacking this parameter to the getter -- return non-null even if constructor is called with explicitly null responseHeaders parameter.EvidenceKeyFilterWhitelist
:inclusionList
asIEnumerable<string>
rather thanList<string>
(orIReadOnlyDictionary<string, int>
rather thanDictionary<string, int>
) -- as they are never mutated and don't need to depend on specific container implementation.EvidenceKeyFilterAggregator
:AsyncLazyFailable
implementation.TaskExtensions.WithCancellation
implementation.CloudRequestEngine
andPipeline
reacting toIFlowData
processing cancellation.Why
Test results
.nupkg
built by 📦 https://github.com/postindustria-tech/pipeline-dotnet/actions/runs/11406530090Screenshots
(new stacktrace)
(unaffected)