Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF2 2.0 with the new syntax #442

Open
wants to merge 12 commits into
base: experimental
Choose a base branch
from
Open

FF2 2.0 with the new syntax #442

wants to merge 12 commits into from

Conversation

naydef
Copy link
Contributor

@naydef naydef commented Oct 4, 2017

Everything is conveted: freak_fortress_2.sp, subplugins, include file and even the README.MD.

Also there will be another pull request regarding the use of some OOP features.

Already done

@naydef
Copy link
Contributor Author

naydef commented Oct 21, 2017

This is the complete pull request

@50Wliu 50Wliu self-assigned this Oct 21, 2017
@@ -247,7 +248,7 @@ native FF2_GetClientDamage(client);
* @param damage New damage dealt
* @noreturn
*/
native FF2_SetClientDamage(client, damage);
native void FF2_SetClientDamage(int lient, int damage);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c in int client was eaten up here 👍

Copy link
Contributor Author

@naydef naydef Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops. Very nice

@naydef
Copy link
Contributor Author

naydef commented Jun 1, 2018

If there are no other corrections to be made, this will be merged soon!

@50Wliu
Copy link
Member

50Wliu commented Jun 1, 2018

Preferably this is rebased on master first so that Travis passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants