Display objects from extensions in the new object dialog #8126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ian
reviewed
Jan 14, 2026
| void EventsBasedObject::SerializeToExternal(SerializerElement& element) const { | ||
| element.SetAttribute("defaultName", defaultName); | ||
| if (!assetStoreTag.empty()) { | ||
| element.SetAttribute("assetStoreTag", assetStoreTag); |
D8H
force-pushed
the
object-list-with-extension
branch
from
f2c4a5a to
6e671fe
Compare
4ian
reviewed
Jan 14, 2026
| : styles.container | ||
| : { ...styles.container, opacity: 0.384 } | ||
| } | ||
| onMouseEnter={() => setHover(true)} |
Owner
There was a problem hiding this comment.
use onPointerEnter/Leave to handle pens and other pointing devices
4ian
reviewed
Jan 14, 2026
| <Line expand noMargin> | ||
| <Column expand noMargin> | ||
| <SearchBar | ||
| id="extension-search-bar" |
4ian
reviewed
Jan 14, 2026
| <ExtensionInstallDialog | ||
| project={project} | ||
| isInstalling={false} | ||
| // TODO isInstalling={isInstalling} |
Owner
There was a problem hiding this comment.
Important to do to avoid multiple clicks while something is installed?
4ian
reviewed
Jan 14, 2026
| description: string, | ||
| extensionName: string, | ||
| assetStoreTag: ?string, | ||
| /** This attribute is calculated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories
Changes