[DRAFT] implementation of Shadowmapping #7592
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D8H
reviewed
May 5, 2025
Extensions/3D/DirectionalLight.ts
Outdated
Comment on lines
29
to
38
| this.light.position.set(1, 0, 0); | ||
| this.light.castShadow = true; | ||
| this.light.shadow.mapSize.width = 1024; | ||
| this.light.shadow.mapSize.height = 1024; | ||
| this.light.shadow.camera.near = 0.1; | ||
| this.light.shadow.camera.far = 10; | ||
| this.light.shadow.camera.right = 10; | ||
| this.light.shadow.camera.left = 10; | ||
| this.light.shadow.camera.top = 10; | ||
| this.light.shadow.camera.bottom = 10; | ||
| this.light.position.set(0, 20, 0); |
There was a problem hiding this comment.
Forgotten small change for better visualization of the light with the lightHelper in my gdevelop game (does not modify behavior)
There was a problem hiding this comment.
The change of axis is not an issue?
There was a problem hiding this comment.
It is not, it only changes the "direction" of the directionalLight, but it still is a light that (should) casts shadow normally
NeylMahfouf2608
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried implementing the built-in shadowmapping system of threeJS exposed here (this implementation is only for DirectionalLight, but the concept is the same for each type of light):
https://threejs.org/examples/webgl_shadowmap_viewer.html
a course on the subject (very short) : https://threejs-journey.com/lessons/shadows#
In my implementation, i forced every required booleans absolutely everywhere it could be necessary. I did not have any good result with this way, nor with a more precise implementation. I push this for clarity.
I have only two theories to explain why there is no shadows :