Snapshot Save Single Action

[NeylMahfouf2608]

Save and/or load the whole game using the updateFromNetworkSyncData/getNetworkSyncData methods to write/read a complete JSON. Done in one action for each (at the moment, might change). Right now it writes both on a localFile and localStorage of the browser.

[NeylMahfouf2608]

I wrote NaN as a value is mandatory. -1 isnt enough as it can be set in the editor.

[ClementPasteau]

I don't understand your logic.
Why is channel mandatory?
If you think it should not be mandatory, then make the private property mandatory:

private _channel: float | undefined;

Then you don't have to set NaN here

[ClementPasteau]

here you can simplify this if/else by doing a:

await gdjs.saveToIndexedDB(
  INDEXED_DB_NAME,
  storageName || INDEXED_DB_KEY,
  INDEXED_DB_OBJECT_STORE,
  syncDataJson
);

[ClementPasteau]

I don't understand your logic.
Why is channel mandatory?
If you think it should not be mandatory, then make the private property mandatory:

private _channel: float | undefined;

Then you don't have to set NaN here

[ClementPasteau]

here you're passing availableResources & cachedSpatialPosition but you're not using them when updating the network sync data?

[ClementPasteau]

you've added a try catch in the load on the open() function but not here.

So either add it here,
or remove it and add the try catch around everything like I suggested before.
You don't need to check if indexedDB doesn't exist like you do above, just try using it and try doing the promise and everything... BUT with a try catch around everything.

In any case, be consistent between the load and the save function

[ClementPasteau]

This logic is wrong. you don't need to check on !syncOptions.forceSyncEverything you always sync this

[ClementPasteau]

let's add this name, only if forceSyncEverything, otherwise don't (just to save a bit of bandwidth...)
so: n: syncOptions && syncOptions.forceSyncEverything ? this.name : undefined

[ClementPasteau]

are those values cleared the next time we use the function without the sceneVar and storageName?

If not, I think we should always set the value from what's coming from the props of the function.
This will allow setting undefined or whatever string/variable is passed

[ClementPasteau]

let's not access a private variable from another object here (doing currentScene._loadVariable)

you're doing the same for _loadStorageName below.

I think that instead of having 2 props in runtimescene, you should have 1 object:
_loadRequestOptions = { storageName: ?string, storageVariable: ?Variable }

And you can get it with a method getLoadingRequestOptions() - something like that

[ClementPasteau]

let's make it so it can be undefined: n?: string (so that we don't pass it if multiplayer)