Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make macOS build universal #5269

Closed
wants to merge 1 commit into from
Closed

Make macOS build universal #5269

wants to merge 1 commit into from

Conversation

jtsorlinis
Copy link

@jtsorlinis jtsorlinis commented May 2, 2023

This consolidates the 2 separate Mac builds into one universal binary.

I needed to update the electron builder dependancy to support the universal build target.

There is a small file size increase in the .app file but I feel like this will simplify the download process for the majority of users.

  • GDevelop 5-5.1.160-mac.zip: 127.5 MB
  • GDevelop 5-5.1.160-arm64-mac.zip: 129.5 MB
  • GDevelop 5-5.1.160-universal-mac.zip: 195.6 MB

The website will have to be updated to update the download links, I'm happy to make a PR for that too.

I'm unable to test this with circleCI but it worked locally.

@jtsorlinis jtsorlinis requested a review from 4ian as a code owner May 2, 2023 05:27
@ClementPasteau
Copy link
Collaborator

Thanks for the contribution @jtsorlinis !

In order to test the CI, I will create a new branch with your commit, which will trigger the pipeline.
I will close this PR and open a new one.

@ClementPasteau
Copy link
Collaborator

Created #5270
Closing this PR to avoid having a doublon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants