Skip to content

fix/ui-fixes #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
4gray merged 3 commits into from
Dec 14, 2025
Merged

fix/ui-fixes #687

4gray merged 3 commits into from
Dec 14, 2025
+65 −8

Conversation

@4gray
Copy link
Owner

@4gray 4gray commented Dec 14, 2025

Summary

  • Removed redundant light-theme CSS block from playlist item stylesheet.
  • Prevented global hotkeys from triggering while typing in input/textarea fields.
  • Re-enabled text selection for input/textarea and added a context menu with Cut/Copy/Paste/Select All for focused editable fields.

What changed

  • CSS: deleted an unnecessary media query that duplicated .meta color styling in recent-playlists playlist-item stylesheet.
  • Hotkeys: added an isTypingInInput(event) helper and short-circuited global key handlers (info key and digit keys) when event target is an input or textarea.
  • Input UX: re-enabled user selection for input and textarea elements and added an Electron context menu handler that shows an edit menu for recognized text inputs, respecting editFlags.

Why

  • Simplifies CSS, reduces redundancy and maintenance overhead.
  • Prevents hotkeys from interfering with normal text entry (e.g., typing numbers or text in forms).
  • Restores native editing UX (selection, copy/paste) and provides a focused context menu for editable fields.

Notes

  • Visual behavior across themes preserved.
  • Context menu only appears for recognized text input types or editable fields and respects edit flags.

4gray added 2 commits December 14, 2025 17:01
@4gray
style: remove redundant light-theme CSS block from playlist item
8482e7c 
Delete an unnecessary media query that set `.meta` color for the
light color scheme in the recent-playlists playlist-item stylesheet.
The rule duplicated default styling and added extra specificity,
so removing it simplifies the CSS and avoids redundant overrides.

This reduces stylesheet size and potential maintenance confusion while
preserving visual behaviour across themes.
@4gray
fix(video-player): ignore hotkeys when typing in search input
c2c06a9 
Prevent global hotkeys from triggering while the user is typing in
input or textarea fields. Add a private isTypingInInput(event) helper
and short-circuit key handlers (info key and digit keys) to return
early when the event target is an input or textarea.

This avoids interfering with normal text entry (e.g., entering numbers
in forms) and prevents accidental overlay toggles or channel changes
while the user is focused on a form field.
@vercel
Copy link

vercel bot commented Dec 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
iptvnator Error Error Dec 14, 2025 4:12pm

@coderabbitai
Copy link

coderabbitai bot commented Dec 14, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1) 
Validation error: Unrecognized key(s) in object: 'auto_review'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/ui-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Dec 14, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a5685ef

Command Status Duration Result
nx run electron-backend:make ✅ Succeeded 11m 12s View ↗
nx build electron-backend ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-14 16:26:26 UTC

@4gray
feat(ui): re-enable input selection and add context menu
a5685ef 
Re-enable user selection for input and textarea elements so users
can select and copy text in form fields. Add an Electron context
menu handler that shows a focused edit menu only for recognized
text input types or editable fields. The menu includes Cut, Copy,
Paste and Select All and respects the editFlags to enable actions.

This restores native editing UX in the renderer while avoiding
global context menus elsewhere in the app.
@4gray 4gray merged commit ebc085c into nx Dec 14, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@4gray