ci/macos-arch-runners-update #678
Merged
+236
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note
|
|
View your CI Pipeline Execution ↗ for commit 7fa7143
☁️ Nx Cloud last updated this comment at |
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
from
f7ce4fa to
1457651
Compare
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
from
1457651 to
2bf0eab
Compare
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
from
2bf0eab to
45e7aad
Compare
Update GitHub Actions workflow to support multiple OS runners and CPU architectures, standardize matrix keys, and adjust platform-specific steps and artifact names. - Replace simple os matrix with include entries specifying os, runner, and arch to allow macOS x64/arm64 separation and explicit runners for linux/windows. - Use runner matrix value for runs-on and change timeout/strategy accordingly. - Adjust conditional checks to use normalized os values (linux, macos, windows) rather than platform-specific runner labels. - Install Linux system deps only when os == 'linux' and keep Flatpak setup for electron-builder. - Add a macOS-specific make step that passes the architecture to the electron make command, while keeping a combined make step for non-macOS builds. - Upload macOS artifacts per architecture and rename artifact paths to include arch; update release files list to include both macOS x64 and arm64 artifact patterns. These changes enable reliable, architecture-aware macOS builds, prevent native module conflicts across runners, and ensure artifacts are labeled and uploaded correctly.
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
from
45e7aad to
1793be4
Compare
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
from
1793be4 to
35f2a2e
Compare
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
from
2824d93 to
57db764
Compare
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
from
57db764 to
4d9ef79
Compare
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
from
4d9ef79 to
ab26b6f
Compare
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
from
ab26b6f to
c902d23
Compare
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
from
c902d23 to
e440210
Compare
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
from
e440210 to
743f42a
Compare
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
2 times, most recently
from
8d21ad0 to
f615251
Compare
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
from
f615251 to
09d8ff7
Compare
Add a publish-snap job to the CI workflow that runs after build and only triggers for version tags (refs/tags/v*). The job downloads the linux build artifacts, installs snapcraft, locates the generated .snap file and uploads it to the Snapcraft Store releasing to the stable channel. It validates the presence of a snap file and fails if none is found. This enables automated Snap distribution for tagged releases using the SNAPCRAFT_STORE_CREDENTIALS secret.
Improve sandbox handling on Linux by detecting Snap, Flatpak, and AppImage environments and applying appropriate Chromium command-line switches: - If running in Snap or Flatpak, disable Chromium's sandbox (--no-sandbox) to avoid conflicts with the distribution's own sandboxing. - Otherwise (traditional packages and AppImage), disable the SUID sandbox and prefer the user namespace sandbox (--disable-setuid-sandbox). This avoids requiring a SUID chrome-sandbox binary and aligns with modern Linux best practices. Also adjust apps/electron-backend/src/main.ts to only apply these changes on Linux (process.platform === 'linux'). Minor formatting: expand the package.json copy "filter" array to a multiline style for readability.
Add a Troubleshooting section to the README covering two common platform-specific launch issues and how to resolve them. - macOS: document Gatekeeper "App is damaged and can't be opened" and show how to clear the quarantine flag with xattr. - Linux: document chrome-sandbox SUID permission error and provide two solutions — fix permissions (chown/chmod) for packaged installs, or run with --no-sandbox by editing the desktop launcher or using the command line. These instructions reduce user confusion and support requests by providing clear, actionable steps to get IPTVnator running on affected systems.
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
from
09d8ff7 to
cf5d88a
Compare
4gray
force-pushed
the
ci/macos-arch-runners-update
branch
from
a064444 to
7fa7143
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issues / PRs
What changed
Notes for reviewers