-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Waku v0.22 community adapter useRouter update #963
Conversation
useRouter is no longer unstable in Waku since v0.22.
@rmarscher is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Maybe we could add a comment about how to import it in older versions?
Since community adapters don't have SemVer ranges enforced in a package.json, I'm not sure what's the best strategy to deliver them over time:
- Always target latest
- Have a semver range added as a comment at the top of the file
- Other ideas?
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks! I added a comment and edited the title of this PR to include that waku version number. I think most people currently running Waku are following pretty closely as the API has been unstable pre-1.0. Targeting the latest and letting people look at the community adapter git history is probably fine. I don't expect it to change moving forward so this shouldn't be too much of an issue. |
🎉 This PR is included in version 2.4.2-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
useRouter is no longer unstable in Waku since v0.22.