Update build workflow to mirror seedsigner-os compose build #211
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| APP_REF="${{ github.event_name == 'workflow_dispatch' && github.event.inputs['source-ref'] || github.sha }}" | ||
| SS_ARGS="--${{ matrix.target }} --app-repo=${APP_REPO_URL} --app-commit-id=${APP_REF}" |
There was a problem hiding this comment.
When building PRs, APP_REF is set to ${{ github.sha }} (lines 111‑113), which for pull_request events is the synthetic refs/pull/*/merge SHA. The workflow no longer checks out the app repo locally and instead passes this SHA to the compose build via --app-commit-id, so the builder has to clone the repo and check out that commit. The merge SHA is not present in the repo’s advertised refs, so the checkout will fail or fall back to the default branch, meaning PR builds will either break or build the wrong code. Use the PR head SHA (e.g., github.event.pull_request.head.sha) or provide the sources directly to compose.
Useful? React with 👍 / 👎.
Description
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Codex Task