feat(search): live search while typing, debounced at 100ms#6754
Draft
meyerlor wants to merge 1 commit into3liz:masterfrom
Draft
feat(search): live search while typing, debounced at 100ms#6754meyerlor wants to merge 1 commit into3liz:masterfrom
meyerlor wants to merge 1 commit into3liz:masterfrom
Conversation
- Auto-search triggers after 3 characters typed (debounced 100ms) - Manual submit always fires regardless of input length - Browser history suggestions disabled on search input - Extracted _performFtsSearch() and _performExternalSearch() for shared use between submit and input event handlers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @mdouchin in #6733 a draft implementation of a live search - it's not really "autocomplete" rather then "autoexecute" but that made it simpler to implement.
_performFtsSearch()and_performExternalSearch()for shared use between submit and input event handlers