Render QGIS CheckBox-widget fields as real checkboxes in popups#6750
Open
meyerlor wants to merge 1 commit into3liz:masterfrom
Open
Render QGIS CheckBox-widget fields as real checkboxes in popups#6750meyerlor wants to merge 1 commit into3liz:masterfrom
meyerlor wants to merge 1 commit into3liz:masterfrom
Conversation
Fields configured with a CheckBox edit widget in QGIS previously
displayed their raw value ("Ja", "Nein", "true", "false", etc.) in the
feature popup, instead of mirroring the editing form's native checkbox.
This change covers two popup render paths:
* Auto popup (popupDefaultContent, popup_all_features_table):
new jTpl modifier popupcheckbox is used in place of featurepopup;
receives a per-layer map of CheckBox fields resolved from the QGIS
project XML by WMSRequest::getCheckBoxFieldsForLayer.
* QGIS/form popup (popupSource=form|qgis):
WMSRequest::applyCheckBoxesToFormPopup post-processes the form HTML
returned by QGIS Server, replacing the text inside each
<span id="dd_jforms_view_edition_FIELD" class="jforms-control-input">
with a disabled <input type="checkbox"> when the field is a
CheckBox widget.
Matching is lenient so the common real-world variants all render as
checkboxes: the configured CheckedState/UncheckedState, common boolean
representations (true/t/1/yes/on and false/f/0/no/off) for fields
stored as boolean, and null-like values ('', NULL, QGIS's '()') which
render as unchecked.
Fixes 3liz#6748
meyerlor
force-pushed
the
feat/popup-checkbox-widget
branch
from
2479b75 to
ce55b9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fields configured with a CheckBox edit widget in QGIS previously displayed their raw value ("Ja", "Nein", "true", "false", etc.) in the feature popup, instead of mirroring the editing form's native checkbox.
This change covers two popup render paths:
Auto popup (popupDefaultContent, popup_all_features_table): new jTpl modifier popupcheckbox is used in place of featurepopup; receives a per-layer map of CheckBox fields resolved from the QGIS project XML by WMSRequest::getCheckBoxFieldsForLayer.
QGIS/form popup (popupSource=form|qgis): WMSRequest::applyCheckBoxesToFormPopup post-processes the form HTML returned by QGIS Server, replacing the text inside each with a disabled when the field is a CheckBox widget.
Matching is lenient so the common real-world variants all render as checkboxes: the configured CheckedState/UncheckedState, common boolean representations (true/t/1/yes/on and false/f/0/no/off) for fields stored as boolean, and null-like values ('', NULL, QGIS's '()') which render as unchecked.
Fixes #6748
For Auto-Popups:
For Drag n Drop Forms:
