[Bug] Reset file input after upload in Draw panel#6446
Merged
rldhont merged 1 commit into3liz:masterfrom Jan 31, 2026
Merged
Conversation
mind84
changed the title
rldhont
approved these changes
Jan 27, 2026
Collaborator
|
@mind84 are you able to add an e2e test ? |
rldhont
added
sponsored development
Collaborator
Author
Collaborator
|
I have rebuild the draw import tests and will be able to add a test for your fix #6507 |
This was referenced Jan 31, 2026
rldhont
added a commit
to rldhont/lizmap-web-client
that referenced
this pull request
Jan 31, 2026
Linked to 3liz#6446 which is the fix part.
3liz-bot
pushed a commit
that referenced
this pull request
Feb 1, 2026
Linked to #6446 which is the fix part.
3liz-bot
pushed a commit
that referenced
this pull request
Feb 1, 2026
Linked to #6446 which is the fix part.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you load a file into the drawing panel and delete the newly added feature, and then want to load the same old file, the feature will not be added.
vokoscreenNG-2026-01-22_10-34-50.webm
The reason is related to the
inputfile which cannot trigger thechangeevent since it maintains the reference to the same file.A quick solution is to reset the input value as soon as the feature is loaded, but it's important to first define how this functionality is intended.
In my opinion, uploading is intended only as a quick way to draw/replicate a feature, which the user can then make changes to. It should also be possible to reload the same feature, even multiple times. In this scenario, the file name next to the
inputwould be understood as "last uploaded file", otherwise it would lose any further relevance.Alternatively, it should be possible for the user to manually reset the input file, but this seems a bit over-engineered for such a feature to me.
What do you think?
Backport relaese 3.9 and 3.10
Funded by Faunalia